We have investigated the contribution to ionic selectivity of residues in the selectivity filter and pore helices of the P1 and P2 domains in the acid sensitive potassium channel TASK-1. We used site directed mutagenesis and electrophysiological studies, assisted by structural models built through computational methods. We have measured selectivity in channels expressed in Xenopus oocytes, using voltage clamp to measure shifts in reversal potential and current amplitudes when Rb+ or Na+ replaced extracellular K+. Both P1 and P2 contribute to selectivity, and most mutations, including mutation of residues in the triplets GYG and GFG in P1 and P2, made channels non-selective. We interpret the effects of these--and of other mutations--in terms of the way the pore is likely to be stabilised structurally. We show also that residues in the outer pore mouth contribute to selectivity in TASK-1. Mutations resulting in loss of selectivity (e.g. I94S, G95A) were associated with slowing of the response of channels to depolarisation. More important physiologically, pH sensitivity is also lost or altered by such mutations. Mutations that retained selectivity (e.g. I94L, I94V) also retained their response to acidification. It is likely that responses both to voltage and pH changes involve gating at the selectivity filter.